[PATCH v2 2/4] shell32/autocomplete: Encapsulate the listbox into an owner window

[Huw Davies]

On Mon, Apr 01, 2019 at 03:24:40PM +0300, Gabriel Ivăncescu wrote:
> On 4/1/19 3:22 PM, Huw Davies wrote:
> > On Mon, Apr 01, 2019 at 02:14:18PM +0300, Gabriel Ivăncescu wrote:
> > > On 4/1/19 10:55 AM, Huw Davies wrote:
> > > > On Thu, Mar 28, 2019 at 02:24:30PM +0200, Gabriel Ivăncescu wrote:
> > > > > Signed-off-by: Gabriel Ivăncescu <gabrielopcode at gmail.com>
> > > > > ---
> > > > >    dlls/shell32/autocomplete.c | 69 +++++++++++++++++++++++++++----------
> > > > >    1 file changed, 51 insertions(+), 18 deletions(-)
> > > > > 
> > > > 
> > > > This doesn't look good:
> > > > 
> > > > ../../../tools/runtest -q -P wine -T ../../.. -M shell32.dll -p shell32_test.exe.so autocomplete && touch autocomplete.ok
> > > > 0009:fixme:msg:pack_message msg 138 (WM_CTLCOLORSTATIC) not supported yet
> > > > 0009:err:win:DefWindowProcW called for other process window 0x10020
> > > > 
> > > > Huw.
> > > > 
> > > 
> > > Sorry, I'm not sure what causes that, it doesn't show up here or on the
> > > testbot. Is there a chance it's a one-off error, or is it consistent on your
> > > setup? I'll try to investigate it more regardless.
> > 
> > Yes, this is consistent for me, at least on macOS.  It's because you
> > set the parent of the static window to be the desktop window.
> > 
> > Huw.
> > 
> 
> Ah I see, thanks. I guess it's time to finally use a proper WS_POPUP window
> instead of the WS_CHILD hack (which was there from the beginning)? Or should
> I find another way?

Yes, I don't see why it needs to be a child window.

Huw.