[PATCH] Disable multithreaded DirectX tests if WINETEST_NO_MT_OPENGL is set.

Francois Gouget fgouget at codeweavers.com
Tue Apr 2 12:19:55 CDT 2019


On Tue, 2 Apr 2019, Henri Verbeet wrote:

> On Tue, 2 Apr 2019 at 15:17, Francois Gouget <fgouget at codeweavers.com> wrote:
> >
> > The nouveau graphics driver's support for multithreaded OpenGL is
> > buggy at least up to (18.2.8) so that any Wine test that performs
> > multithreaded OpenGL accesses freezes, crashes the Mesa stack and
> > eventually freezes the whole computer. Typically the first such test
> > is d2d1:d2d1.
> > The relevant tests have a --single option but WineTest neither knows
> > which tests accept this option, nor whether it is needed for the
> > current host.
> > The WINETEST_NO_MT_OPENGL environnement variable can be set on hosts
> > that need it (such as the cw2-gtx560 box) and is automatically
> > inherited by the relevant tests thus working around this issue.
> >
> Works for me. If you're not attached to the name though, could I
> suggest WINETEST_NO_MT_D3D (or perhaps simply WINETEST_NO_MT)? OpenGL
> is somewhat of a wined3d implementation detail, and this environment
> variable would also affect the tests running on Windows or with the
> wined3d Vulkan backend.

Makes sense.
I think WINETEST_NO_MT is too generic though: one could think it 
applies to kernel32's threading tests. So I'll resubmit the patch with 
WINETEST_NO_MT_D3D.

-- 
Francois Gouget <fgouget at codeweavers.com>



More information about the wine-devel mailing list