[PATCH 1/5] uianimation: Add IUIAnimationManager stub
Zebediah Figura
z.figura12 at gmail.com
Wed Apr 3 13:57:10 CDT 2019
On 04/03/2019 12:15 PM, Vijay Kiran Kamuju wrote:
> +static HRESULT WINAPI manager_CreateAnimationVariable( IUIAnimationManager *iface, DOUBLE initial_value, IUIAnimationVariable **variable )
> +{
> + struct manager *This = impl_from_IUIAnimationManager( iface );
> + FIXME( "stub (%p)->( )\n", This );
> + return E_NOTIMPL;
> +}
Is there a reason you're not tracing parameter values?
> +HRESULT manager_create( IUnknown *outer, REFIID iid, void **obj )
> +{
> + struct manager *This = heap_alloc( sizeof(*This) );
> + HRESULT hr;
> +
> + if (!This) return E_OUTOFMEMORY;
> + This->IUIAnimationManager_iface.lpVtbl = &manager_vtbl;
> + This->ref = 1;
> +
> + hr = IUIAnimationManager_QueryInterface( &This->IUIAnimationManager_iface, iid, obj );
> +
> + IUIAnimationManager_Release( &This->IUIAnimationManager_iface );
> + return hr;
> +}
> +
This isn't used anywhere, so you're effectively introducing a bunch of
dead code.
Tests would also be nice.
More information about the wine-devel
mailing list