[PATCH] combase/tests: Remove a no longer useful test

[Detlef Riekenberg]

Microsoft changed the behavior from returning NULL into returning a valid pointer

Machines returning NULL:
win8 upto win10 build 1709(cw2-gtx560-1709-t64: combase 10.0.16299.15)


Example test failures
From the 90 failure package after updating from win7 to win10 (combase: 10.0.17763.253):
http://test.winehq.org/queue/err5iRR8/report

cw1-hd6800-1803-t64 (combase 10.0.17134.619)
http://test.winehq.org/queue/errL2Ivr/report


Patch tested:
https://testbot.winehq.org/JobDetails.pl?Key=50529

--
bye bye ...
        ... Detlef

Signed-off-by: Detlef Riekenberg <wine.dev at web.de>
---
 dlls/combase/tests/string.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dlls/combase/tests/string.c b/dlls/combase/tests/string.c
index 7a705da297..96e99c535b 100644
--- a/dlls/combase/tests/string.c
+++ b/dlls/combase/tests/string.c
@@ -227,7 +227,9 @@ static void test_string_buffer(void)

     /* Test creation of an empty buffer */
     ok(pWindowsPreallocateStringBuffer(0, &ptr, &buf) == S_OK, "Failed to preallocate string buffer\n");
-    ok(buf == NULL, "Empty string buffer isn't a null string\n");
+    /* testing the returned value in buf is no longer useful:
+       Win10 build 1709 and earlier versions returned NULL,
+       while Win10 build 1803 and other updated combase.dll return a valid pointer */
     ok(ptr != NULL, "Empty string didn't return a buffer pointer\n");
     ok(pWindowsPromoteStringBuffer(buf, &str) == S_OK, "Failed to promote string buffer\n");
     ok(str == NULL, "Empty string isn't a null string\n");
--
2.21.0.windows.1