[PATCH 2/2] winex11.drv: Corrected prototype of sync_gl_drawable used when opengl headers aren't found

Ken Thomases ken at codeweavers.com
Wed Apr 10 13:25:04 CDT 2019


Ah, the new one actually reached me first, so I thought this was the corrected one.  Never mind. :)

> On Apr 10, 2019, at 12:10 PM, Micah N Gorrell <mgorrell at codeweavers.com> wrote:
> 
> I thought this email had been lost because I had git misconfigured and sent from
> the wrong email address. I sent a corrected version from my correct email
> address.
> 
> Sorry for the confusion.
> 
> -Micah
> 
> On Wed, Apr 10, 2019 at 12:02:05PM -0500, Ken Thomases wrote:
>> You can't do this in a separate patch.  Patches aren't allowed to introduce brokenness, even temporarily in a patch series.
>> 
>> -Ken
>> 
>>> On Apr 9, 2019, at 2:33 PM, Micah N Gorrell <mgorrell at crossover.com> wrote:
>>> 
>>> Signed-off-by: Micah N Gorrell <mgorrell at crossover.com>
>>> ---
>>> dlls/winex11.drv/opengl.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>> 
>>> diff --git a/dlls/winex11.drv/opengl.c b/dlls/winex11.drv/opengl.c
>>> index 0d4fb521c4..3a983f70a8 100644
>>> --- a/dlls/winex11.drv/opengl.c
>>> +++ b/dlls/winex11.drv/opengl.c
>>> @@ -3369,7 +3369,7 @@ struct opengl_funcs *get_glx_driver( UINT version )
>>>    return NULL;
>>> }
>>> 
>>> -void sync_gl_drawable( HWND hwnd, HWND child )
>>> +void sync_gl_drawable( HWND hwnd, BOOL have_child )
>>> {
>>> }
>>> 
>>> -- 
>>> 2.21.0
>>> 
>>> 
>>> 
>> 
>> 
>> 




More information about the wine-devel mailing list