[PATCH v3 03/11] server: Allow creating process kernel objects.

Jacek Caban jacek at codeweavers.com
Thu Apr 11 14:37:37 CDT 2019


On 4/11/19 8:26 PM, Derek Lesho wrote:
> -    sizeof(struct process),      /* size */
> -    process_dump,                /* dump */
> -    process_get_type,            /* get_type */
> -    add_queue,                   /* add_queue */
> -    remove_queue,                /* remove_queue */
> -    process_signaled,            /* signaled */
> -    no_satisfied,                /* satisfied */
> -    no_signal,                   /* signal */
> -    no_get_fd,                   /* get_fd */
> -    process_map_access,          /* map_access */
> -    default_get_sd,              /* get_sd */
> -    default_set_sd,              /* set_sd */
> -    no_lookup_name,              /* lookup_name */
> -    no_link_name,                /* link_name */
> -    NULL,                        /* unlink_name */
> -    no_open_file,                /* open_file */
> -    no_kernel_obj_list,          /* get_kernel_obj_list */
> -    no_close_handle,             /* close_handle */
> -    process_destroy              /* destroy */
> +    sizeof(struct process),         /* size */
> +    process_dump,                   /* dump */
> +    process_get_type,               /* get_type */
> +    add_queue,                      /* add_queue */
> +    remove_queue,                   /* remove_queue */
> +    process_signaled,               /* signaled */
> +    no_satisfied,                   /* satisfied */
> +    no_signal,                      /* signal */
> +    no_get_fd,                      /* get_fd */
> +    process_map_access,             /* map_access */
> +    default_get_sd,                 /* get_sd */
> +    default_set_sd,                 /* set_sd */
> +    no_lookup_name,                 /* lookup_name */
> +    no_link_name,                   /* link_name */
> +    NULL,                           /* unlink_name */
> +    no_open_file,                   /* open_file */
> +    process_get_kernel_object_list, /* get_kernel_obj_list */


Please use a name consistent with other objects. It's slightly shorter 
so you'd avoid changing all those comments...


Jacek




More information about the wine-devel mailing list