[PATCH] gdi32: Reformat some strings to improve readability
Alexandre Julliard
julliard at winehq.org
Sat Apr 13 07:59:48 CDT 2019
Henri Verbeet <hverbeet at gmail.com> writes:
> On Sat, 13 Apr 2019 at 11:19, Alexandre Julliard <julliard at winehq.org> wrote:
>> Rather than converting everything over to u"", I'd prefer that we find
>> ways to use L"".
>>
>> For instance, I'm currently working on building more modules with
>> MSVCRT, and converting them to use wchar functions instead of
>> unicode.h. Such modules could be built with -fshort-wchar. Ultimately
>> this would hopefully cover a large fraction of the code base.
>>
> D3D code doesn't have a lot of UTF-16 string literals, so this is
> perhaps more curiosity than anything else, but other than legacy
> compiler support, are there any other advantages of L"" over u""? My
> impression was that -fshort-wchar was fairly hopeless as soon as you
> use any external API with wchar_t in it, including e.g. libstdc++.
I don't expect that we'll be using libstdc++ in Wine anytime soon.
And there are very few other wchar_t APIs that we would want to use,
that's too painful.
As far as porting code with Winelib, existing Windows code would already
be using L"" everywhere, so having a solution for that would be better
than requiring a massive search/replace.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list