[PATCH 1/7] qedit/tests: Add more tests for sample grabber filter interfaces.

[Zebediah Figura]

On 4/15/19 11:30 PM, Francois Gouget wrote:
> On Sun, 14 Apr 2019, Zebediah Figura wrote:
> [...]
>>> === w2008s64 (64 bit report) ===
>>>
>>> qedit:
>>> samplegrabber.c:31: Test failed: Got hr 0x80040154.
>>> 0460:samplegrabber: unhandled exception c0000005 at 0000000000403180
>>>
>>>
>>
>> This is a little confusing. w2008s64 doesn't ship qedit, and winetest
>> accordingly doesn't run it. Shouldn't the TestBot also skip it?
> 
> That's because WineTest uses the executable's filename to guess which
> dll is being tested and check whether it is present.
> 
> But that does not work for the TestBot since the user can upload
> executables with arbitrary names. So the TestBot's TestLauncher (which
> replaces WineTest.exe) grabs the list of dlls that the executable links
> with and checks whether they are present.
> 
> But qedit_test.exe does not link with qedit.dll since it's all COM. So
> all looks fine and TestLauncher runs the test.
> 

I see. What do you recommend as the solution to this problem?