[PATCH] shell32: SHCreateDirectoryExW no CANCELLED for ALREADY_EXISTS

[Zhiyi Zhang]

On 4/16/19 1:58 PM, John Thomson wrote:
> On Tue, 16 Apr 2019, at 12:20, Zhiyi Zhang wrote:
>> You can write some conformance tests and verify the behavior on 
>> TestBots(https://testbot.winehq.org/)
> Thanks!
>
> I submitted another email with just the tests, sorry for the noise.
> I was not sure if a reply patch would be picked up?
> It looks like it worked on Windows.
> I manually downloaded the built exe, and it failed on unpatched Wine.
>
> I wasn't able to build the Windows test executable with mingw myself.
> Has make crosstest changed, or it is just me?
crosstest is gone as part of the building PE dll changes.

make -C dlls/shell32/tests and copy the shell32_test.exe in dlls/shell32/tests to test it on windows.

You can also submit the patch directly to Testbot, which I would recommend.

Your tests failed. Please fix it.
>
>> "SHCreateDirectoryExW returned %d. Expected %d",
> I missed a newline at the end of one of the ok strings
>
> Should I add this newline, squash both of my commits, and submit a new version of this patch?
> Any other hints or comments?
You can send a new version and add a v2 to the subject for example.
>
> Thank you!