Re: [PATCH] shell32/tests Add SHCreateDirectoryExW with Hwnd ALREADY_EXISTS

John Thomson git at johnthomson.fastmail.com.au
Tue Apr 16 19:18:47 CDT 2019


On Wed, 17 Apr 2019, at 07:00, Francois Gouget wrote:
> This ok() call is wrong: it is missing the trailing '\n'.
> So the fix is to:
> * Add the trailing '\n'.
> * Either fix the test or add a todo_wine so it does not fail on Wine.
> * And for bonus points fix Wine's implementation if it is indeed wrong.

Thanks.
Yes, I do believe this test showed Wine's implementation differs to Windows,
given that the Windows tests passed, and the Wine test failed.
As long as my test logic is sound?


This test patch is included as part of my updated fix:
shell32: SHCreateDirectoryExW no CANCELLED for ALREADY_EXISTS

Cheers,
-- 
  John Thomson



More information about the wine-devel mailing list