[PATCH] taskschd/tests: Avoid a crash in a test after E_ACCESSDENIED

Detlef Riekenberg wine.dev at web.de
Tue Apr 16 12:42:47 CDT 2019


Example crash on Win10 v1709 or newer
http://test.winehq.org/data/f9301c2b66450a1cdd986e9052fcaa76535ba8b7/win10_cw1-hd6800-1709-t64/taskschd:scheduler.html
http://test.winehq.org/data/f9301c2b66450a1cdd986e9052fcaa76535ba8b7/win10_dr-i7-v3-x64/taskschd:scheduler.html

Patch tested:
https://testbot.winehq.org/JobDetails.pl?Key=51061

--
bye bye ...
        ... Detlef

Signed-off-by: Detlef Riekenberg <wine.dev at web.de>
---
 dlls/taskschd/tests/scheduler.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/dlls/taskschd/tests/scheduler.c b/dlls/taskschd/tests/scheduler.c
index 639555ecae..c03ecd35b9 100644
--- a/dlls/taskschd/tests/scheduler.c
+++ b/dlls/taskschd/tests/scheduler.c
@@ -946,6 +946,11 @@ todo_wine
     ok(hr == HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND) || hr == S_OK /* win7 */, "expected ERROR_FILE_NOT_FOUND, got %#x\n", hr);

     hr = ITaskFolder_RegisterTask(root, NULL, xmlW, TASK_CREATE, v_null, v_null, TASK_LOGON_NONE, v_null, &task1);
+    if(hr == E_ACCESSDENIED)
+    {
+        skip("Access denied\n");
+        goto no_access;
+    }
     ok(hr == S_OK, "RegisterTask error %#x\n", hr);

     hr = IRegisteredTask_get_Name(task1, &bstr);
@@ -962,6 +967,7 @@ todo_wine
     hr = ITaskFolder_RegisterTask(folder, NULL, xmlW, TASK_CREATE, v_null, v_null, TASK_LOGON_NONE, v_null, &task1);
     ok(hr == E_INVALIDARG, "expected E_INVALIDARG, got %#x\n", hr);

+no_access:
     ITaskFolder_Release(folder);

     hr = ITaskFolder_DeleteFolder(root, Wine, 0);
--
2.21.0.windows.1




More information about the wine-devel mailing list