[PATCH] winex11: The correct way to search the target window for drag&drop operations.

Zebediah Figura z.figura12 at gmail.com
Thu Apr 18 12:53:35 CDT 2019


On 04/18/2019 12:35 PM, John Found wrote:
> On Thu, 18 Apr 2019 12:09:02 -0500
> Zebediah Figura <z.figura12 at gmail.com> wrote:
> 
>>
>> Really? I'm looking at this test right here:
>>
>> <https://source.winehq.org/git/wine.git/blob/refs/heads/master:/dlls/user32/tests/win.c#l9398>
>>
> 
> Well, yes, I am wrong about the WindowFromPoint, but still only the first level of the children is checked.
> 
> The mentioned test checks exactly this in 3 cases:
> 
> 1. Main window without child created - main window returned.
> 2. Main window with single STATIC child created - main window returned. (correct, according to MSDN)
> 3. Main window with single BUTTON child created - the child returned.
> 
> There is no child-in-child cases (and IMHO, should not be).
> 

Really? Why not? Our implementation is recursive, so it should return
the deepest child. If it's wrong, we should add tests to prove it.



More information about the wine-devel mailing list