[PATCH resend] include/wine/unicode: Avoid scanning the entire string in memrchrW

Gabriel Ivăncescu gabrielopcode at gmail.com
Mon Apr 22 10:48:25 CDT 2019


On 4/22/19 6:22 PM, Alexandre Julliard wrote:
> Gabriel Ivăncescu <gabrielopcode at gmail.com> writes:
> 
>> Scanning backwards can avoid a full scan of the entire string and makes
>> more sense since we are looking for the last char.
> 
> It was done this way for symmetry with the other similar functions.
> I don't think it's necessary to change it.
> 

Yeah I realized it was probably a copy-paste thing. I think it's better 
this way scanning backwards, since it's less code and slightly less 
overhead. It also makes more sense in my opinion. But it's your call :-)



More information about the wine-devel mailing list