[PATCH 4/7] comctl32/button: Implement command links

[Gabriel Ivăncescu]

On 4/22/19 4:53 PM, Nikolay Sivov wrote:
> Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
> 
> On 4/19/19 3:14 PM, Gabriel Ivăncescu wrote:
>> Signed-off-by: Gabriel Ivăncescu <gabrielopcode at gmail.com>
>> ---
>>
>> Command Links have hot-tracking even when they don't use a theme. The 
>> default
>> glyph (green arrow) is used when the button has no image (bitmap/icon) or
>> imagelist, and seems to be hardcoded (i.e. BM_GETIMAGE and 
>> BCM_GETIMAGELIST
>> must return NULL to pass the tests).
>>
>> I've added the glyph as a bitmap with 3 hardcoded states to avoid 
>> duplication,
>> they are very close to the ones in Windows 7 in appearance. I don't know
>> where Windows stores them but I placed them in comctl32's resources. They
>> were created from scratch by just filling a custom-drawn arrow shape and
>> adding a white outline + shadow to it. (I can supply the 1024x1024 
>> original
>> image before I downsampled it, if that's needed)
> Please create a bug report for command link support, if we don't have 
> one yet, and attach your original image file there so it's not lost.
> 
> 

Thanks, I will do that. I only have the "normal" state as 1024x1024 
(first image in the bitmap), would that be enough? If not I can 
re-create the other states as 1024x1024 (just have to change the filling 
gradient and the outline color, also remove the shadow on the disabled 
state, shouldn't be a problem).