[PATCH] gdi32/tests: Remove a useless test
Detlef Riekenberg
wine.dev at web.de
Tue Apr 23 04:56:52 CDT 2019
Dimitry wrote:
>
> > --- a/dlls/gdi32/tests/dc.c
> > +++ b/dlls/gdi32/tests/dc.c
> > @@ -815,9 +815,6 @@ static void test_DeleteDC(void)
> > ret = UnregisterClassA("Wine class DC", GetModuleHandleA(NULL));
> > ok(ret, "UnregisterClassA failed\n");
> >
> > - ret = GetObjectType(hdc_test);
> > - ok(!ret, "GetObjectType should fail for a deleted DC\n");
>
> It should be changed to add broken() instead of removing a perfectly
> > valid test.
No. The test is a "Use after free" Bug
The result of the function-call is an implementation Detail
and can change with every Update.
Microsoft changed the function-result more than a year ago...
There are more 'Use after free' bugs in this file,
but the others did not produce test failures yet.
--
Bye bye ...
... Detlef
More information about the wine-devel
mailing list