[RFC PATCH 1/2] kernel32: Move implementation of {Get,Write}PrivateProfileStringW() to helper.

Dmitry Timoshkov dmitry at baikal.ru
Tue Apr 23 05:17:08 CDT 2019


Jactry Zeng <jzeng at codeweavers.com> wrote:

> > +    lstrcpyA(expected_val, "\xe9\x85\x92\x2e");
> > +    len = MultiByteToWideChar(CP_ACP, 0, expected_val, -1, expected_valW, MAX_PATH) - 1;
> >
> > You should not rely on CP_ACP being compatible with the multibyte string.
> This just want to get an expected result which corresponding to native GetPrivateProfileStringW()'s.

This can't work reliably, the test should be made to return reasonable
results under different locales.

-- 
Dmitry.



More information about the wine-devel mailing list