[PATCH 1/5] dxgi: Implement dxgi_factory_MakeWindowAssociation().

Zhiyi Zhang zzhang at codeweavers.com
Wed Apr 24 07:27:13 CDT 2019



On 4/24/19 6:48 PM, Henri Verbeet wrote:
> On Wed, 24 Apr 2019 at 07:15, Zhiyi Zhang <zzhang at codeweavers.com> wrote:
>> On 4/24/19 1:54 AM, Henri Verbeet wrote:
>>> Would it make sense to adapt the existing wined3d_wndproc_table in
>>> wined3d to handle DXGI window associations?
>>>
>> I am sure it will make more sense. If we use wined3d_wndproc_table then it doesn't explain
Sorry, typo. I shouldn't get up so early and reply emails. I meant I am *not* sure it will make more sense
>> why set up a hook to ignore WM_SYSKEYDOWN breaks Alt+Enter, or why SendMessage(WM_SYSKEYDOWN)
>> don't trigger Alt+Enter while PostMessage(WM_SYSKEYDOWN) does. It seems more accurate to
>> set up a hook to intercept message before GetMessage returns.
>>
>> Another thing may be of interest. Application doesn't receive a WM_SYSKEYDOWN(Alt+Enter) when Alt+Enter
>> is pressed.
> I'm not objecting to using hooks, although it would still be good to
> have tests to validate that e.g. MakeWindowAssociation() or swapchain
I'll add more tests.
> creation doesn't change GWLP_WNDPROC on the window. It seems
> undesirable though to track the window to swapchain/device association
> in two different places, and to a lesser extent the same goes for
> handling the events themselves.
Right. It doesn't look nice this way. MakeWindowAssociation being in IDXGIFactory
puzzles me at the very start. I haven't found a way for it to look nicer.



More information about the wine-devel mailing list