[PATCH] kernel32/pipe: Avoid a crash in a test
Detlef Riekenberg
wine.dev at web.de
Tue Apr 23 12:19:21 CDT 2019
Recent Windows versions crash on the NULL parameter in the test
Examples:
http://test.winehq.org/data/75aa4ab16b03a11464ab0d3e4c4cfbff0180c269/win8_dr-RS740-wow/kernel32:pipe.html
http://test.winehq.org/data/75aa4ab16b03a11464ab0d3e4c4cfbff0180c269/win8_dr-RS740-x64/kernel32:pipe.html
http://test.winehq.org/data/f9301c2b66450a1cdd986e9052fcaa76535ba8b7/win10_dr-i7-v3-x64/kernel32:pipe.html
patch tested:
https://testbot.winehq.org/JobDetails.pl?Key=51469
https://testbot.winehq.org/GetFile.pl?JobKey=51469&StepKey=2 and
https://testbot.winehq.org/GetFile.pl?JobKey=51469&StepKey=3 are
working on dr-RS740-*
--
bye bye ...
... Detlef
Signed-off-by: Detlef Riekenberg <wine.dev at web.de>
---
dlls/kernel32/tests/pipe.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/dlls/kernel32/tests/pipe.c b/dlls/kernel32/tests/pipe.c
index 3f30cce535..cb41bc6a60 100644
--- a/dlls/kernel32/tests/pipe.c
+++ b/dlls/kernel32/tests/pipe.c
@@ -3572,10 +3572,13 @@ static void test_namedpipe_session_id(void)
create_overlapped_pipe(PIPE_TYPE_BYTE, &client, &server);
- SetLastError(0xdeadbeef);
- ret = pGetNamedPipeClientSessionId(server, NULL);
- ok(!ret, "success\n");
- todo_wine ok(GetLastError() == ERROR_INSUFFICIENT_BUFFER, "got %u\n", GetLastError());
+ /* This crash on recent Windows */
+ if (0)
+ {
+ SetLastError(0xdeadbeef);
+ ret = pGetNamedPipeClientSessionId(server, NULL);
+ ok(!ret, "success\n");
+ }
id = 0;
ret = pGetNamedPipeClientSessionId(server, &id);
--
2.21.0.windows.1
More information about the wine-devel
mailing list