[PATCH 3/5] wmp: Return E_POINTER when p is NULL in return_bstr.
Gijs Vermeulen
gijsvrm at gmail.com
Thu Aug 1 07:47:21 CDT 2019
Signed-off-by: Gijs Vermeulen <gijsvrm at codeweavers.com>
---
dlls/wmp/tests/media.c | 1 -
dlls/wmp/wmp_private.h | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/dlls/wmp/tests/media.c b/dlls/wmp/tests/media.c
index 3d750e13b2..7e76aee744 100644
--- a/dlls/wmp/tests/media.c
+++ b/dlls/wmp/tests/media.c
@@ -535,7 +535,6 @@ static void test_media_item(void)
hr = IWMPPlayer4_newMedia(player, NULL, &media);
ok(hr == S_OK, "Failed to create a media item, hr %#x.\n", hr);
hr = IWMPMedia_get_name(media, NULL);
-todo_wine
ok(hr == E_POINTER, "Unexpected hr %#x.\n", hr);
hr = IWMPMedia_get_name(media, &str);
ok(hr == S_OK, "Failed to get item name, hr %#x.\n", hr);
diff --git a/dlls/wmp/wmp_private.h b/dlls/wmp/wmp_private.h
index 5149d73942..0b1b02305f 100644
--- a/dlls/wmp/wmp_private.h
+++ b/dlls/wmp/wmp_private.h
@@ -135,7 +135,7 @@ static inline WCHAR *heap_strdupW(const WCHAR *str)
static inline HRESULT return_bstr(const WCHAR *value, BSTR *p)
{
if(!p)
- return E_INVALIDARG;
+ return E_POINTER;
if(value) {
*p = SysAllocString(value);
--
2.22.0
More information about the wine-devel
mailing list