[PATCH] kernel32: Check dwFlags parameter in QueryFullProcessImageNameW().

Dmitry Timoshkov dmitry at baikal.ru
Thu Aug 1 08:31:06 CDT 2019


Serge Gautherie <winehq-git_serge_180711 at gautherie.fr> wrote:


> >> @@ -4030,6 +4030,12 @@ BOOL WINAPI QueryFullProcessImageNameW(HANDLE hProcess, DWORD dwFlags, LPWSTR lp
> >>       NTSTATUS status;
> >>       DWORD needed;
> >>
> >> +    if (dwFlags >= 2)
> >> +    {
> >> +        SetLastError(ERROR_INVALID_PARAMETER);
> >> +        return FALSE;
> >> +    }
> >
> > What does that mean?
> 
> I am not sure what you are asking for.

I'm asking what that magic check is supposed to do.

> To succeed tests!?

Why?

> > Is there an application that depends on this?
> 
> I don't know indeed.
> 
> > If you don't know, then it's better to not add anything like this.
> 
> Is Wine not interested in validating parameters (values), then?

Validating parameters makes sense when it makes an application work.

-- 
Dmitry.



More information about the wine-devel mailing list