[PATCH v10 2/9] server: Move mouse raw-input message faking from user32 to wineserver.

Zebediah Figura zfigura at codeweavers.com
Mon Aug 5 11:55:25 CDT 2019


On 8/5/19 11:25 AM, Derek Lesho wrote:
> Zebediah,
> I think that using hw_input_t for rawinput would make the code harder
> to follow.  To do it this way we'd probably want to transform RAWINPUT
> into the custom fields of hw_input_t from __wine_send_input, and
> decipher the result on the server side.  Using a hw_rawinput_t allows
> us to more closely match the internal data structures of windows from
> the display drivers / user32.
> 

I'm not sure I see how this is harder. It's the same thing we currently 
do, except now we're adding another couple of fields for raw messages. 
That way, we don't have to add any extra logic, we just pass more data 
along the same paths.

I also don't see why matching internal data structures should be a goal 
of ours.



More information about the wine-devel mailing list