[PATCH] d3d9: Remove duplicate condition in d3d9_device_SetStreamSource().

Henri Verbeet hverbeet at gmail.com
Tue Aug 6 09:22:28 CDT 2019


On Mon, 5 Aug 2019 at 22:33, Andrey Gusev <andrey.goosev at gmail.com> wrote:
>      if (!buffer_impl)
> +    {
>          wined3d_device_get_stream_source(device->wined3d_device, stream_idx, &wined3d_buffer,
>                  &offset, &stride);
> -
> -    if (!buffer_impl)
>          wined3d_buffer = NULL;
> +    }
>      else if (buffer_impl->draw_buffer)
>          wined3d_buffer = buffer_impl->draw_buffer;
>      else
The change is not necessarily wrong, but I'm not sure it's an
improvement either. The compiler doesn't care, and I can't say it
makes things more readable.



More information about the wine-devel mailing list