[PATCH] ddraw: implement Pick() and GetPickRecords().

Henri Verbeet hverbeet at gmail.com
Tue Aug 6 09:48:11 CDT 2019


On Fri, 2 Aug 2019 at 23:16, MattKC <itsmattkc at gmail.com> wrote:
> I would agree it's not very efficient, however I believe it is accurate
> to how the function is intended to work according to the SDK
> documentation.
>
DirectDraw 1 applications tend to not be especially performance
critical on modern hardware, so in that regard it's fine. What is a
concern though is d3d_execute_buffer_execute_pick() diverging from
d3d_execute_buffer_execute() when changes are made to one or the
other.

> I don't have any tests I'm afraid, I used the two games I mentioned to
> develop this patch.
>
Having tests is important, both in order to be sure the implementation
is correct as well as to prevent future changes from breaking it.



More information about the wine-devel mailing list