[PATCH 1/4] shell32/shfldr_mycomp: Fail properly when parsing display name

Gabriel Ivăncescu gabrielopcode at gmail.com
Wed Aug 21 06:32:39 CDT 2019


Signed-off-by: Gabriel Ivăncescu <gabrielopcode at gmail.com>
---

Currently the code doesn't fail at all if an invalid path is specified.

 dlls/shell32/shfldr_mycomp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/shell32/shfldr_mycomp.c b/dlls/shell32/shfldr_mycomp.c
index 6a31e8c..1b987a7 100644
--- a/dlls/shell32/shfldr_mycomp.c
+++ b/dlls/shell32/shfldr_mycomp.c
@@ -228,7 +228,7 @@ static HRESULT WINAPI ISF_MyComputer_fnParseDisplayName (IShellFolder2 *iface,
         hr = SHELL32_ParseNextElement (iface, hwndOwner, pbc, &pidlTemp,
                               (LPOLESTR) szNext, pchEaten, pdwAttributes);
     }
-    else
+    else if (pidlTemp)
     {
         if (pdwAttributes && *pdwAttributes)
             SHELL32_GetItemAttributes (&This->IShellFolder2_iface, pidlTemp, pdwAttributes);
-- 
2.21.0




More information about the wine-devel mailing list