[PATCH resend 3/3] ntdll: Implement RtlIpv4StringToAddress(Ex)W

Alex Henrie alexhenrie24 at gmail.com
Fri Aug 23 14:38:05 CDT 2019


On Fri, Aug 23, 2019 at 12:27 PM Alexandre Julliard <julliard at winehq.org> wrote:
>
> Alex Henrie <alexhenrie24 at gmail.com> writes:
>
> > On Fri, Aug 23, 2019 at 11:38 AM Alexandre Julliard <julliard at winehq.org> wrote:
> >>
> >> It doesn't seem right to have the W function call the A implementation,
> >> it should be the other way around.
> >
> > I can certainly do it the other way around, but since IP addresses can
> > only contain ASCII characters, why does it matter?
>
> Checking for ASCII characters after the W->A conversion doesn't
> guarantee that they were ASCII to begin with, the conversion is lossy.

That makes perfect sense. Thanks for the explanation!

-Alex



More information about the wine-devel mailing list