[PATCH 4/7] user32: Implement GetRegisteredRawInputDevices

Rémi Bernon rbernon at codeweavers.com
Tue Aug 27 03:09:03 CDT 2019


On 8/27/19 1:03 AM, Marvin wrote:
> Hi,
> 
> While running your changed tests, I think I found new failures.
> Being a bot and all I'm not very good at pattern recognition, so I might be
> wrong, but could you please double-check?
> 
> Full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=55813
> 
> Your paranoid android.
> 
> 
> === debian10 (32 bit report) ===
> 
> user32:
> msg.c:5145: Test succeeded inside todo block: ShowWindow(SW_SHOWMINIMIZED):overlapped: marked "todo_wine" but succeeds
> 
> Report errors:
> user32:msg prints too much data (35221 bytes)
> 
> === debian10 (32 bit Chinese:China report) ===
> 
> user32:
> msg.c:5145: Test succeeded inside todo block: ShowWindow(SW_SHOWMINIMIZED):overlapped: marked "todo_wine" but succeeds
> 
> Report errors:
> user32:msg prints too much data (35221 bytes)
> 
> === debian10 (32 bit WoW report) ===
> 
> user32:
> msg.c:5145: Test succeeded inside todo block: ShowWindow(SW_SHOWMINIMIZED):overlapped: marked "todo_wine" but succeeds
> 
> Report errors:
> user32:msg prints too much data (35221 bytes)
> 
> === debian10 (64 bit WoW report) ===
> 
> user32:
> msg.c:5145: Test succeeded inside todo block: ShowWindow(SW_SHOWMINIMIZED):overlapped: marked "todo_wine" but succeeds
> 
> Report errors:
> user32:msg prints too much data (35221 bytes)
> 

I don't see how this is related. Also, it looks like from the full logs 
that the test is actually failing but is reported as succeeding inside 
todo, which is weird.

When testing on my side the user32 msg tests are triggering a crash in 
mutter, but work fine with openbox (and do not report any failure for 
this patch). Wouldn't it be better to use openbox - or any other WM that 
doesn't crash spuriously - for the automated regression tests?
-- 
Rémi Bernon <rbernon at codeweavers.com>



More information about the wine-devel mailing list