[PATCH 4/4] httpapi: Implement HttpReceiveHttpRequest().

[Dmitry Timoshkov]

Zebediah Figura <z.figura12 at gmail.com> wrote:

> >> +    struct http_receive_request_params params =
> >> +    {
> >> +        .addr = (ULONG_PTR)request,
> >> +        .id = id,
> >> +        .flags = flags,
> >> +        .bits = sizeof(void *) * 8,
> >> +    };
> > 
> > Please don't do this, it won't build with some compilers.
> > 
> 
> Do you mean the use of designated initializers?

Yes. It's pretty easy to avoid it, and there's no any real need to
abuse this kind of strange syntax.

> We've had those in the 
> code base for over 6 years:
> 
> https://source.winehq.org/git/wine.git/commitdiff/cf0334b6542
> https://source.winehq.org/git/wine.git/commitdiff/0fa08f47937e

Looks like this slipped through somehow.

> Do you have a concrete example of a compiler that doesn't recognize these?

PSDK compiler chokes on it, and I already had to patch locally that
windowscodecs test in order to build it.

-- 
Dmitry.