[PATCH v2 1/3] wininet: Return error from HttpQueryInfo if number argument is invalid.

Alexandre Julliard julliard at winehq.org
Wed Aug 28 11:18:45 CDT 2019


Daniel Lehman <dlehman25 at gmail.com> writes:

> +        value = strtoulW( lphttpHdr->lpszValue, NULL, 10 );
> +        if (value >= UINT_MAX)
> +        {
> +            LeaveCriticalSection( &request->headers_section );
> +            return ERROR_HTTP_INVALID_HEADER;
> +        }

Is UINT_MAX really supposed to fail? Otherwise you need an errno
check. Either way, some more test cases would be a good idea.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list