[PATCH v3 2/7] wined3d: Add functions to support device local and non-local memory info management.
hverbeet at gmail.com
Mon Dec 2 05:08:26 CST 2019
On Mon, 2 Dec 2019 at 12:14, Conor McCarthy <cmccarthy at codeweavers.com> wrote:
> November 27, 2019 6:01 AM, "Henri Verbeet" <hverbeet at gmail.com> wrote:
> > On Mon, 25 Nov 2019 at 17:43, Conor McCarthy <cmccarthy at codeweavers.com> wrote:
> > Is it ever necessary to override the total amount of video memory?
> If the totals come from adapter_vk they will be correct, but adapter_gl won't have the non-local total. Should a zero total be overridden by a non-zero one? Also should totals be passed in a separate call? That could be done using a more generic messaging callback function.
The GL backend won't be able to query the amount of non-local video
memory (unless we add an extension, perhaps), but ultimately that's an
implementation detail, and I'm not sure how much it really matters.
Chances are we'll ultimately get that information from winex11.
> > If we have wined3d_get_adapter_memory_info(), the memory information
> > in struct wined3d_adapter_identifier becomes redundant and could be
> > removed.
> Should vram_bytes and sysmem_bytes stay in wined3d_driver_info though?
Well, they need to be stored somewhere, but that doesn't necessarily
need to be the wined3d_driver_info structure. If you think a separate
structure for adapter memory info makes sense, that's fine.
More information about the wine-devel