[PATCH] wininet/tests: Increase the maximum expected available data value.
Jacek Caban
jacek at codeweavers.com
Wed Dec 4 10:58:38 CST 2019
Hi Francois,
On 11/28/19 1:41 PM, Francois Gouget wrote:
> With each Windows version InternetQueryDataAvailable() reports a
> different value. 8192 from XP/2003 to Vista/2008; then 1460 from
> Windows 7 to Windows 10 1709; and 24000 starting with Windows 10 1809.
>
> Signed-off-by: Francois Gouget <fgouget at free.fr>
> ---
>
> This fixes a failure on Windows 10 1809. I'm not entirely sure it makes
> sense to check for this value. If we do, maybe we should leave a
> bigger margin? Like < 31000? Not that it did us much good last time...
Maybe we should use a significantly higher value in hope that we will
not have to increase it with the next Windows update? The exact value is
not important, the point is that not whole data is reported when amount
of pending data is large enough.
> Also, shouldn't we check that it is greater than some minimum value?
> Like at least 1000?
Sure, sounds good.
Thanks,
Jacek
More information about the wine-devel
mailing list