[PATCH] testbot/LogUtils: Fix GetNewLogErrors() when there are no errors.

Francois Gouget fgouget at codeweavers.com
Thu Dec 5 03:53:28 CST 2019


Don't use $Groups if it is undefined.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---

This fixes WineSendLog and thus the patch status and Marvin emails.

 testbot/lib/WineTestBot/LogUtils.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testbot/lib/WineTestBot/LogUtils.pm b/testbot/lib/WineTestBot/LogUtils.pm
index 51932965c..32bf0fa61 100644
--- a/testbot/lib/WineTestBot/LogUtils.pm
+++ b/testbot/lib/WineTestBot/LogUtils.pm
@@ -889,7 +889,7 @@ sub GetNewLogErrors($$$)
   my ($RefFileName, $Groups, $Errors) = @_;
 
   my (@NewGroups, %NewErrors, %NewIndices);
-  return (\@NewGroups, \%NewErrors, \%NewIndices) if (!@$Groups);
+  return (\@NewGroups, \%NewErrors, \%NewIndices) if (!$Groups or !@$Groups);
 
   my ($RefGroups, $RefErrors) = GetLogErrors($RefFileName);
   return (undef, undef) if (!$RefGroups);
-- 
2.20.1



More information about the wine-devel mailing list