[PATCH] testbot/WineSendLog: Errors are not new when missing reference reports.

Francois Gouget fgouget at codeweavers.com
Thu Dec 5 06:23:04 CST 2019


Build logs don't have reference logs so for them every error is new.
But test reports should have reference WineTest results and if not
reporting the errors as new would cause false positives. So default
to "not new" in that case.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/bin/WineSendLog.pl | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/testbot/bin/WineSendLog.pl b/testbot/bin/WineSendLog.pl
index 721122edb..95cc036c9 100755
--- a/testbot/bin/WineSendLog.pl
+++ b/testbot/bin/WineSendLog.pl
@@ -291,8 +291,11 @@ EOF
       my ($NewGroups, $NewErrors, $_NewIndices) = GetNewLogErrors($RefFileName, $LogErrors->{Groups}, $LogErrors->{Errors});
       if (!$NewGroups)
       {
-        # There was no reference log (typical of build logs)
-        # so every error is new
+        # Test reports should have reference WineTest results and if not
+        # reporting the errors as new would cause false positives.
+        next if ($LogName =~ /\.report$/);
+
+        # Build logs don't have reference logs so for them every error is new.
         $NewGroups = $LogErrors->{Groups};
         $NewErrors = $LogErrors->{Errors};
       }
-- 
2.20.1



More information about the wine-devel mailing list