[PATCH] wineqtdecoder: Fix macos compile error

Zebediah Figura z.figura12 at gmail.com
Sat Dec 7 09:58:38 CST 2019


On 12/7/19 12:03 AM, Alistair Leslie-Hughes wrote:
> Regression of 498179b4482026091bf7376c0d2ac9a036e7ca0e
> 
> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
> ---
>  dlls/wineqtdecoder/qtsplitter.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 

Hello Alistair, thanks for catching these errors.

> diff --git a/dlls/wineqtdecoder/qtsplitter.c b/dlls/wineqtdecoder/qtsplitter.c
> index 5b1e82ebc9b..956dd0a7d0d 100644
> --- a/dlls/wineqtdecoder/qtsplitter.c
> +++ b/dlls/wineqtdecoder/qtsplitter.c
> @@ -285,7 +285,7 @@ static HRESULT qt_splitter_start_stream(struct strmbase_filter *iface, REFERENCE
>      QTSplitter *filter = impl_from_strmbase_filter(iface);
>      HRESULT hr = VFW_E_NOT_CONNECTED, pin_hr;
>  
> -    EnterCriticalSection(&This->csReceive);
> +    EnterCriticalSection(&filter->csReceive);
>  
>      if (filter->pVideo_Pin)
>          pin_hr = BaseOutputPinImpl_Active(&filter->pVideo_Pin->pin);
> @@ -297,7 +297,7 @@ static HRESULT qt_splitter_start_stream(struct strmbase_filter *iface, REFERENCE
>          hr = pin_hr;
>      SetEvent(filter->runEvent);
>  
> -    LeaveCriticalSection(&This->csReceive);
> +    LeaveCriticalSection(&filter->csReceive);
>  
>      return hr;
>  }
> @@ -306,10 +306,10 @@ static HRESULT qt_splitter_cleanup_stream(struct strmbase_filter *iface)
>  {
>      QTSplitter *filter = impl_from_strmbase_filter(iface);
>  
> -    EnterCriticalSection(&This->csReceive);
> +    EnterCriticalSection(&filter->csReceive);
>      IAsyncReader_BeginFlush(filter->pInputPin.pReader);
>      IAsyncReader_EndFlush(filter->pInputPin.pReader);
> -    LeaveCriticalSection(&This->csReceive);
> +    LeaveCriticalSection(&filter->csReceive);
>  
>      return S_OK;
>  }
> @@ -1170,8 +1170,6 @@ static HRESULT WINAPI QTOutPin_QueryInterface(IPin *iface, REFIID riid, void **p
>          *ppv = iface;
>      else if (IsEqualIID(riid, &IID_IPin))
>          *ppv = iface;
> -    else if (IsEqualIID(riid, &IID_IMediaSeeking))
> -        *ppv = &This->sourceSeeking.IMediaSeeking_iface;
>      else if (IsEqualIID(riid, &IID_IQualityControl))
>          *ppv = &This->IQualityControl_iface;
>  
> 

Did you mean to do this?



More information about the wine-devel mailing list