[PATCH] httpapi: return ERROR_SUCCESS for unimplemented flags in HttpInitialize

Austin English austinenglish at gmail.com
Sun Dec 8 23:11:27 CST 2019

Returning ERROR_CALL_NOT_IMPLEMENTED breaks .Net installers. MSDN suggests
that ERROR_INVALID_PARAMETER may be more appropriate, but that too breaks .Net.

Note that this is (currently) only effective if mingw is disabled. mingw enabled builds has
separate issues that I'm still looking into.

Signed-off-by: Austin English <austinenglish at gmail.com>
 dlls/httpapi/httpapi_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/httpapi/httpapi_main.c b/dlls/httpapi/httpapi_main.c
index 0449d53045..8adbd38be5 100644
--- a/dlls/httpapi/httpapi_main.c
+++ b/dlls/httpapi/httpapi_main.c
@@ -62,7 +62,7 @@ ULONG WINAPI HttpInitialize(HTTPAPI_VERSION version, ULONG flags, void *reserved
     if (flags & ~HTTP_INITIALIZE_SERVER)
         FIXME("Unhandled flags %#x.\n", flags);
+        return ERROR_SUCCESS;
     if (!(manager = OpenSCManagerW(NULL, NULL, SC_MANAGER_CONNECT)))

More information about the wine-devel mailing list