[PATCH 01/10] jscript: Add script TypeInfo stub.

Gabriel Ivăncescu gabrielopcode at gmail.com
Mon Dec 9 09:27:05 CST 2019


On 12/9/19 4:54 PM, Jacek Caban wrote:
> Hi Gabriel,
> 
> On 12/9/19 3:01 PM, Gabriel Ivăncescu wrote:
>> +
>> +    if (This == This->ctx->global)
>> +        return create_script_typeinfo(This, ppTInfo);
> 
> 
> That's not pretty. However, do you depend on jsdisp_t being a script 
> dispatch anywhere? It seems to me that this could be just a generic 
> implementation (although that would need some tests).
> 
> 
> Thanks,
> 
> Jacek
> 

Right, I wanted to keep it similar to vbscript. I'll look into adding 
some tests for it.

But just in case tests show that it applies only to script dispatch, 
would this current approach work? (i.e. should I resend it?)



More information about the wine-devel mailing list