[PATCH] winecfg: Avoid an unneeded strlen() call.

Francois Gouget fgouget at free.fr
Tue Dec 10 02:36:31 CST 2019


Note that szLinkTarget is an array field and thus cannot be NULL.

Signed-off-by: Francois Gouget <fgouget at free.fr>
---
 programs/winecfg/theme.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/programs/winecfg/theme.c b/programs/winecfg/theme.c
index 66d23448f6f..dffe1861e82 100644
--- a/programs/winecfg/theme.c
+++ b/programs/winecfg/theme.c
@@ -842,7 +842,7 @@ static void on_shell_folder_selection_changed(HWND hDlg, LPNMLISTVIEW lpnm) {
     if (lpnm->uNewState & LVIS_SELECTED) {
         psfiSelected = (struct ShellFolderInfo *)lpnm->lParam;
         EnableWindow(GetDlgItem(hDlg, IDC_LINK_SFPATH), 1);
-        if (strlen(psfiSelected->szLinkTarget)) {
+        if (*psfiSelected->szLinkTarget) {
             WCHAR *link;
             CheckDlgButton(hDlg, IDC_LINK_SFPATH, BST_CHECKED);
             EnableWindow(GetDlgItem(hDlg, IDC_EDIT_SFPATH), 1);
-- 
2.20.1




More information about the wine-devel mailing list