[PATCH] wineqtdecoder: Fix macos compile error

Matteo Bruni matteo.mystral at gmail.com
Tue Dec 10 03:07:48 CST 2019


On Sun, Dec 8, 2019 at 4:22 AM Mathew Hodson <mathew.hodson at gmail.com> wrote:
>
> On Sat, Dec 7, 2019 at 1:03 AM Alistair Leslie-Hughes
> <leslie_alistair at hotmail.com> wrote:
> >
> > Regression of 498179b4482026091bf7376c0d2ac9a036e7ca0e
> >
> > Signed-off-by: Alistair Leslie-Hughes <leslie_alistair at hotmail.com>
> > ---
> >  dlls/wineqtdecoder/qtsplitter.c | 10 ++++------
> >  1 file changed, 4 insertions(+), 6 deletions(-)
> >
> > diff --git a/dlls/wineqtdecoder/qtsplitter.c b/dlls/wineqtdecoder/qtsplitter.c
> > index 5b1e82ebc9b..956dd0a7d0d 100644
> > --- a/dlls/wineqtdecoder/qtsplitter.c
> > +++ b/dlls/wineqtdecoder/qtsplitter.c
> > @@ -285,7 +285,7 @@ static HRESULT qt_splitter_start_stream(struct strmbase_filter *iface, REFERENCE
> >      QTSplitter *filter = impl_from_strmbase_filter(iface);
> >      HRESULT hr = VFW_E_NOT_CONNECTED, pin_hr;
> >
> > -    EnterCriticalSection(&This->csReceive);
> > +    EnterCriticalSection(&filter->csReceive);
>
> Wouldn't the original commit have failed to compile on all platforms?
>
> Where is the This variable defined?

wineqtdecoder is only built and used on macOS.



More information about the wine-devel mailing list