[PATCH 2/5] activeds: Implement ADsOpenObject.
dmitry at baikal.ru
Mon Dec 16 02:52:15 CST 2019
Nikolay Sivov <bunglehead at gmail.com> wrote:
> > > > + hr = IADsOpenDSObject_OpenDSObject(adsopen,
> > (BSTR)path, (BSTR)user, (BSTR)password, reserved, &disp);
> > > > + if (hr == S_OK)
> > > You cannot cast to a BSTR, it will corrupt the data structure.
> > I depends wheather the callee uses SysStringLen() and friends, in this
> > particular case it works just fine, there are many other places in the code
> > when it's not necessary to create intermediate copies of the strings.
> It does not matter if it works in this case, arguments should use correct
> types. If we have similar violations somewhere else, those need fixing as
That's a pretty incorrect assertion, there's nothing wrong in casting
BSTR to LPWSTR and vice versa.
More information about the wine-devel