[PATCH 5/5] adsldp/tests: Add some tests for LDAPNamespace.

Dmitry Timoshkov dmitry at baikal.ru
Mon Dec 16 08:32:41 CST 2019


Sven Baars <sven.wine at gmail.com> wrote:

> On 16-12-2019 15:05, Dmitry Timoshkov wrote:
> > Sven Baars <sven.wine at gmail.com> wrote:
> > 
> >>> +START_TEST(ldap)
> >>> +{
> >>> +    HRESULT hr;
> >>> +
> >>> +    hr = CoInitialize(NULL);
> >>> +    ok(hr == S_OK, "got %#x\n", hr);
> >>> +
> >>> +    test_LDAP();
> >>> +}
> >>>
> >> I think you forgot to call CoUninitialize here.
> > 
> > The process is going to terminate anyway, so it's a waste of time.
> > 
> In that case, you might as well remove all *_Release calls from your
> tests...

*_Release calls in the test help to ensure that reference counting
works correctly, and I do check that when looking at the logs. However
calling CoUninitialize() is meaningless for the test results.

-- 
Dmitry.



More information about the wine-devel mailing list