[PATCH 5/5] adsldp/tests: Add some tests for LDAPNamespace.

[Alexandre Julliard]

Zebediah Figura <z.figura12 at gmail.com> writes:

> On 12/16/19 6:10 AM, Francois Gouget wrote:
>> On Mon, 16 Dec 2019, Dmitry Timoshkov wrote:
>> 
>>> Marvin <testbot at winehq.org> wrote:
>>>
>>>> === debian10 (32 bit report) ===
>>>>
>>>> adsldp:
>>>> ldap.c:45: Test failed: got 0x80040154
>>>> Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x004015c0).
>>>>
>>>> Report errors:
>>>> adsldp:ldap crashed (c0000005)
>>>
>>> testbot is broken and doesn't update Wine prefix.
>> 
>> The TestBot recreates the WinePrefixes from scratch with the daily Wine 
>> commits:
>> 
>> https://source.winehq.org/git/tools.git/blob/HEAD:/testbot/bin/build/WineReconfig.pl#l91
>> 
>> But it does not recreate the wineprefixes from scratch with each patch. 
>> For those it just runs Wine which is supposed to update the wineprefix 
>> automatically.
>> 
>> Not updating the wineprefix automatically would force the users to 
>> delete and recreate their wineprefixes, including reinstalling 
>> applications, every time they upgrade Wine, which I would argue is a 
>> bug.
>> 
>
> I'd agree. Unfortunately, we don't have a way of automatically detecting
> when a new WINE_REGISTRY resource is added to an existing DLL. I'm not
> sure what would be a good solution there (manually updating wine.inf.in?)

wine.inf is updated on every release, so it's not an issue for users.
Developers are expected to be able to figure out such issues and update
manually when necessary (which happens rarely in practice). The testbot
could probably update on every patch, or update and retry when a test
failed.

-- 
Alexandre Julliard
julliard at winehq.org