[PATCH resend v3 2/2] ntdll: Start find_free_area from address_space_start instead of 0.

Rémi Bernon rbernon at codeweavers.com
Tue Dec 24 04:54:50 CST 2019

The search was initiated with base == 0, which returns NULL immediately
if MEM_TOP_DOWN is not used. Use address_space_start instead.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=47974
Signed-off-by: Rémi Bernon <rbernon at codeweavers.com>

The bug is also about some other issue with X Rebirth but these patches
should fix the main crash cause.

 dlls/ntdll/virtual.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/ntdll/virtual.c b/dlls/ntdll/virtual.c
index a29517e286d..985a8f5c89e 100644
--- a/dlls/ntdll/virtual.c
+++ b/dlls/ntdll/virtual.c
@@ -1204,7 +1204,7 @@ static NTSTATUS map_view( struct file_view **view_ret, void *base, size_t size,
         if (zero_bits_64)
-            if (!(ptr = find_free_area( (void*)0, alloc.limit, size, mask, top_down, TRUE, unix_prot )))
+            if (!(ptr = find_free_area( address_space_start, alloc.limit, size, mask, top_down, TRUE, unix_prot )))
                 return STATUS_NO_MEMORY;
             TRACE( "got mem with find_free_area %p-%p\n", ptr, (char *)ptr + size );
             goto done;

More information about the wine-devel mailing list