[PATCH] msvcp140/tests: Don't trace the current time.

Piotr Caban piotr.caban at gmail.com
Mon Dec 30 09:56:25 CST 2019


On 12/30/19 12:06 AM, Francois Gouget wrote:
> This causes the failure to always look new and the last_write_time
> value does not really seem useful.
> 
> Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
> ---
> 
> This also only fails on my box, but it does not change the fact that a
> failure will always look new.
> 
>   dlls/msvcp140/tests/msvcp140.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/dlls/msvcp140/tests/msvcp140.c b/dlls/msvcp140/tests/msvcp140.c
> index 751b1beed86..35a650ddbae 100644
> --- a/dlls/msvcp140/tests/msvcp140.c
> +++ b/dlls/msvcp140/tests/msvcp140.c
> @@ -1239,8 +1239,7 @@ static void test_Last_write_time(void)
>       newtime = last_write_time + 222222;
>       p_Set_last_write_time(f1W, newtime);
>       ok(last_write_time != p_Last_write_time(f1W),
> -            "last_write_time should have changed: %s\n",
> -            wine_dbgstr_longlong(last_write_time));
> +       "last_write_time should have changed\n");
Is the failure caused by filesystem write time resolution? Is it fixed 
by changing 222222 to something bigger than 2 seconds (e.g. 22222200)? 
What filesystem is it not working on?

Thanks,
Piotr



More information about the wine-devel mailing list