[PATCH v4 1/4] d3d9/tests: Add Fetch4 tests

Thu Feb 7 10:42:11 CST 2019

Hi,

I got some failures on r500 on Win7, I've attached the test output. My
guess is that r500 applies fetch4 for ATI1, and there's still the
different green and blue components in DF24.

Evergreen has texldd and texldl failures. I think I did not see them
last time. Weird...

A few comments are inline. The general structure looks good to me.
Am 05.02.19 um 01:19 schrieb Daniel Ansorregui:
> +        BOOL broken_wine;           /* Do not check it on wine because is known to be broken */
I'd prefer the name "todo_wine". Wine isn't broken, it's just not
finished yet :-P. Only windows is broken().

(Jokes aside, I think it makes sense to stick to the names of
"todo_wine" and "broken()")

> +        const char * name;          /* The name of the texture format */
Minor nitpick: "const char *name;"

> +    const BOOL isWin = strcmp(winetest_platform, "wine");
This is not used

> +            get_rt_readback(original_rt, &rb);
> +            D3DCOLOR color = get_readback_color(&rb, format_tests[i].x, format_tests[i].y);            
Trailing whitespace
-------------- next part --------------
visual.c:25267: Driver string: "atiumdag.dll"
visual.c:25268: Description string: "Radeon X1600 Series "
visual.c:25271: Device name string: "\\.\DISPLAY1"
visual.c:25273: Driver version 8.14.10.647
visual.c:1226: sRGB writing to D3DFMT_A8R8G8B8 is supported.
visual.c:1444: Tests skipped: D3DFMT_D16_LOCKABLE is not supported.
visual.c:12080: Tests skipped: D3DFMT_L8 textures not supported as render targets.
visual.c:6650: Tests skipped: D3DFMT_A1R5G5B5 support is not D3DOK_NOAUTOGEN (0).
visual.c:15018: Tests skipped: No INTZ support, skipping INTZ test.
visual.c:15719: Test failed: Test ATI1 on FFP expected color 0x6d6d6d6d at (360, 60), got 0xff6fffff.
visual.c:15719: Test failed: Test ATI1 on texld expected color 0x6d6d6d6d at (360, 60), got 0xff6fffff.
visual.c:15719: Test failed: Test ATI1 on texldp expected color 0x49494949 at (360, 60), got 0xff47ffff.
visual.c:15809: Tests skipped: Skipping D16_LOCKABLE depth test, unsuported format.
visual.c:15809: Tests skipped: Skipping D32 depth test, unsuported format.
visual.c:15809: Tests skipped: Skipping D15S1 depth test, unsuported format.
visual.c:15809: Tests skipped: Skipping D24S8 depth test, unsuported format.
visual.c:15809: Tests skipped: Skipping D24X8 depth test, unsuported format.
visual.c:15809: Tests skipped: Skipping D24X4S4 depth test, unsuported format.
visual.c:15809: Tests skipped: Skipping D16 depth test, unsuported format.
visual.c:15809: Tests skipped: Skipping D32F_LOCKABLE depth test, unsuported format.
visual.c:15809: Tests skipped: Skipping D24FS8 depth test, unsuported format.
visual.c:15883: Test failed: Test OFF Expected color 0xff9f0000 at (260, 15) for format DF24, got 0x9f9f9f9f.
visual.c:15883: Test failed: Test OFF Expected color 0xff800000 at (20, 255) for format DF24, got 0x80808080.
visual.c:15883: Test failed: Test OFF Expected color 0xff600000 at (260, 135) for format DF24, got 0x60606060.
visual.c:15809: Tests skipped: Skipping INTZ depth test, unsuported format.
visual.c:14422: Tests skipped: No NVDB (depth bounds test) support, skipping tests.
visual.c:17341: Tests skipped: No unconditional NP2 texture support, skipping multisampled depth buffer test.
visual.c:17642: Tests skipped: No INTZ support, skipping RESZ test.
visual.c:19329: Tests skipped: Per-stage constants not supported, skipping tests.
visual.c:21412: Tests skipped: 2D mipmapped R32F textures are not supported, skipping some tests.
visual.c:21412: Tests skipped: Cube R32F textures are not supported, skipping some tests.
visual.c:21412: Tests skipped: Volume R32F textures are not supported, skipping some tests.
visual.c:21684: Tests skipped: Depth format 71 not supported, skipping.
visual.c:21684: Tests skipped: Depth format 1515474505 not supported, skipping.
visual.c:23096: Tests skipped: D3DPMISCCAPS_PERSTAGECONSTANT not supported.
visual.c:23485: Line antialiasing support: 0.
visual.c:24223: Tests skipped: No vertex texture fetch support for D3DFMT_A8R8G8B8, hr 0x8876086a.
visual.c:24563: Tests skipped: No NULL format support, skipping NULL test.
097c:visual: 20210 tests executed (0 marked as todo, 6 failures), 26 skipped.
-------------- next part --------------
visual.c:25267: Driver string: "aticfx32.dll"
visual.c:25268: Description string: "AMD Radeon HD 5700 Series"
visual.c:25271: Device name string: "\\.\DISPLAY1"
visual.c:25273: Driver version 8.17.10.1404
visual.c:1226: sRGB writing to D3DFMT_A8R8G8B8 is supported.
visual.c:1444: Tests skipped: D3DFMT_D16_LOCKABLE is not supported.
visual.c:2538: Test failed: Got color 0x0000bf40 for addressing mode D3DTADDRESS_BORDER, expected 0x000000ff.
visual.c:6650: Tests skipped: D3DFMT_A1R5G5B5 support is not D3DOK_NOAUTOGEN (0).
visual.c:10245: Tests skipped: Card has unconditional NP2 support, skipping conditional NP2 tests
visual.c:10642: Tests skipped: L6V5U5 / D3DTOP_BUMPENVMAPLUMINANCE not supported, skipping tests.
visual.c:15669: Test failed: Test texldd Expected color 0x131202f2 at (40, 30), got 0x13131313.
visual.c:15669: Test failed: Test texldd Expected color 0x1211f2f1 at (200, 30), got 0x12121212.
visual.c:15669: Test failed: Test texldd Expected color 0x1110f101 at (360, 30), got 0x11111111.
visual.c:15669: Test failed: Test texldd Expected color 0x10130102 at (520, 30), got 0x10101010.
visual.c:15669: Test failed: Test texldd Expected color 0x02f204f4 at (40, 150), got 0x02020202.
visual.c:15669: Test failed: Test texldd Expected color 0xf2f1f4f3 at (200, 150), got 0xf2f2f2f2.
visual.c:15669: Test failed: Test texldd Expected color 0xf101f303 at (360, 150), got 0xf1f1f1f1.
visual.c:15669: Test failed: Test texldd Expected color 0x01020304 at (520, 150), got 0x01010101.
visual.c:15669: Test failed: Test texldd Expected color 0x04f42322 at (40, 270), got 0x04040404.
visual.c:15669: Test failed: Test texldd Expected color 0xf4f32221 at (200, 270), got 0xf4f4f4f4.
visual.c:15669: Test failed: Test texldd Expected color 0xf3032120 at (360, 270), got 0xf3f3f3f3.
visual.c:15669: Test failed: Test texldd Expected color 0x03042023 at (520, 270), got 0x03030303.
visual.c:15669: Test failed: Test texldd Expected color 0x23221312 at (40, 390), got 0x23232323.
visual.c:15669: Test failed: Test texldd Expected color 0x22211211 at (200, 390), got 0x22222222.
visual.c:15669: Test failed: Test texldd Expected color 0x21201110 at (360, 390), got 0x21212121.
visual.c:15669: Test failed: Test texldd Expected color 0x20231013 at (520, 390), got 0x20202020.
visual.c:15669: Test failed: Test texldl Expected color 0x131202f2 at (40, 30), got 0x13131313.
visual.c:15669: Test failed: Test texldl Expected color 0x1211f2f1 at (200, 30), got 0x12121212.
visual.c:15669: Test failed: Test texldl Expected color 0x1110f101 at (360, 30), got 0x11111111.
visual.c:15669: Test failed: Test texldl Expected color 0x10130102 at (520, 30), got 0x10101010.
visual.c:15669: Test failed: Test texldl Expected color 0x02f204f4 at (40, 150), got 0x02020202.
visual.c:15669: Test failed: Test texldl Expected color 0xf2f1f4f3 at (200, 150), got 0xf2f2f2f2.
visual.c:15669: Test failed: Test texldl Expected color 0xf101f303 at (360, 150), got 0xf1f1f1f1.
visual.c:15669: Test failed: Test texldl Expected color 0x01020304 at (520, 150), got 0x01010101.
visual.c:15669: Test failed: Test texldl Expected color 0x04f42322 at (40, 270), got 0x04040404.
visual.c:15669: Test failed: Test texldl Expected color 0xf4f32221 at (200, 270), got 0xf4f4f4f4.
visual.c:15669: Test failed: Test texldl Expected color 0xf3032120 at (360, 270), got 0xf3f3f3f3.
visual.c:15669: Test failed: Test texldl Expected color 0x03042023 at (520, 270), got 0x03030303.
visual.c:15669: Test failed: Test texldl Expected color 0x23221312 at (40, 390), got 0x23232323.
visual.c:15669: Test failed: Test texldl Expected color 0x22211211 at (200, 390), got 0x22222222.
visual.c:15669: Test failed: Test texldl Expected color 0x21201110 at (360, 390), got 0x21212121.
visual.c:15669: Test failed: Test texldl Expected color 0x20231013 at (520, 390), got 0x20202020.
visual.c:15809: Tests skipped: Skipping D16_LOCKABLE depth test, unsuported format.
visual.c:15809: Tests skipped: Skipping D32 depth test, unsuported format.
visual.c:15809: Tests skipped: Skipping D15S1 depth test, unsuported format.
visual.c:15809: Tests skipped: Skipping D24X4S4 depth test, unsuported format.
visual.c:15809: Tests skipped: Skipping D24FS8 depth test, unsuported format.
visual.c:14422: Tests skipped: No NVDB (depth bounds test) support, skipping tests.
visual.c:20443: Tests skipped: Format D3DFMT_L6V5U5 not supported, skipping.
visual.c:21684: Tests skipped: Depth format 71 not supported, skipping.
visual.c:23485: Line antialiasing support: 0.
0c60:visual: 23841 tests executed (0 marked as todo, 33 failures), 12 skipped.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20190207/46aa986f/attachment.sig>