[PATCH v3] winetest: Add GUI to display results of individual tests.

Zebediah Figura z.figura12 at gmail.com
Tue Feb 12 10:02:43 CST 2019


Apologies once again for the late review.

On 2/1/19 6:39 AM, Isira Seneviratne wrote:
> From 23e71fc6183934102332bce6727dcc882f627d42 Mon Sep 17 00:00:00 2001
> From: Isira-Seneviratne <isirasen96 at gmail.com>
> Date: Sun, 16 Dec 2018 14:59:20 +0530
> Subject: [PATCH v3] winetest: Add GUI to display results of individual tests.
> 
> This patch adds a listview control displaying the results of each
> test, together with the component being tested.
> 
> Signed-off-by: Isira-Seneviratne <isirasen96 at gmail.com>
> ---
>  programs/winetest/gui.c       | 25 +++++++++++++--
>  programs/winetest/main.c      | 60 +++++++++++++++++++++++++++++++++--
>  programs/winetest/resource.h  |  2 ++
>  programs/winetest/winetest.h  |  4 +++
>  programs/winetest/winetest.rc | 20 +++++++-----
>  5 files changed, 99 insertions(+), 12 deletions(-)
> 

I'm still getting some rather noticeable graphical problems with this patch:

* The columns of the listview seem to be too wide to fit in it, making 
an ugly and rather unnecessary horizontal scrollbar appear.

* I'm still seeing multiple lines per test.

* Scrolling doesn't update the header until a test has finished running. 
(This might be a bug in the listview implementation, though.)



More information about the wine-devel mailing list