[PATCH 1/2] d3d9/tests: Add test for buffer read / write.
Henri Verbeet
hverbeet at gmail.com
Tue Feb 12 10:10:30 CST 2019
On Tue, 12 Feb 2019 at 19:39, Paul Gofman <gofmanp at gmail.com> wrote:
> On 2/12/19 18:25, Henri Verbeet wrote:
> > On Tue, 12 Feb 2019 at 15:50, Paul Gofman <gofmanp at gmail.com> wrote:
> >> + static const float tri[][3] =
> >> + {
> >> + {-1.0f, -1.0f, 0.0f},
> >> + {-1.0f, 1.0f, 0.0f},
> >> + { 1.0f, 1.0f, 0.0f},
> >> + };
> > It's pretty minor, but we have "struct vec3" for this kind of thing.
> >
> I would change this declaration but keep 'float *data' to avoid
> component wise comparisons and test output. Or do you think it is better
> to use vec3 for that too?
>
"float *data" is fine.
More information about the wine-devel
mailing list