[PATCH v6 1/4] d3d9/tests: Add Fetch4 tests

Stefan Dösinger stefandoesinger at gmail.com
Fri Feb 15 16:22:47 CST 2019


Hi,

> Am 14.02.2019 um 22:03 schrieb DarkZeros <mailszeros at gmail.com>:
> 
> Hi,
> 
> It looks to me is a simple clamping issue, it fails just on the borders.
> But it would be interesting to see if forcing the wrapping fixes it, or that GPU just is unable to wrap around fetch4 sampling.
Yes, after looking at it a bit more I agree. If I force clamping I get the same results on evergreen and Wine (minus results accidentally accepted by broken()). I have attached test results of Polaris and evergreen with addressmode U and V = clamp. My r500 box is just compiling Gentoo updates, so I'll get comparison results there later.

I see two choices: Either accept the Polaris results as broken, or force clamping everywhere to get the same results everywhere and adjust the expected values accordingly. In theory we could also just not test the borders, but I don't see how that would be better than clamping. My preference is option 2 because with all the ways fetch4 is broken the test accepts too large an amount of results already.

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: polaris.txt
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20190215/44fe278f/attachment.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: evergreen.txt
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20190215/44fe278f/attachment-0001.txt>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Message signed with OpenPGP
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20190215/44fe278f/attachment.sig>


More information about the wine-devel mailing list