[PATCH v6 1/4] d3d9/tests: Add Fetch4 tests

Stefan Dösinger stefandoesinger at gmail.com
Sat Feb 16 12:35:18 CST 2019

Ah yeah, there are also some new warnings that I did not notice on OSX:

../../../../../wine/dlls/d3d9/tests/visual.c: In function ‘fetch4_test’:
../../../../../wine/dlls/d3d9/tests/visual.c:15660:13: warning: ISO C90
forbids mixed declarations and code [-Wdeclaration-after-statement]
             D3DCOLOR color_intel = expected_colors.color_intel[j];
../../../../../wine/dlls/d3d9/tests/visual.c:15711:13: warning: ISO C90
forbids mixed declarations and code [-Wdeclaration-after-statement]
             D3DCOLOR color = get_readback_color(&rb, format_tests[i].x,

On 16/02/2019 19:21, Stefan Dösinger wrote:
> Hi,
> Here are the results from r500 with clamping forced. They look mostly
> the same as the Polaris and Evergreen ones. There are some additional
> failures in texldd, texldb and texldp, I guess because one card applies
> fetch4 and the other ones don't. There are also no new failures in 3D
> textures, which makes sense considering that fetch4 is off for those
> cards on 3D textures.
> Stefan
> On 15/02/2019 23:22, Stefan Dösinger wrote:
>> Hi,
>>> Am 14.02.2019 um 22:03 schrieb DarkZeros <mailszeros at gmail.com>:
>>> Hi,
>>> It looks to me is a simple clamping issue, it fails just on the borders.
>>> But it would be interesting to see if forcing the wrapping fixes it, or that GPU just is unable to wrap around fetch4 sampling.
>> Yes, after looking at it a bit more I agree. If I force clamping I get the same results on evergreen and Wine (minus results accidentally accepted by broken()). I have attached test results of Polaris and evergreen with addressmode U and V = clamp. My r500 box is just compiling Gentoo updates, so I'll get comparison results there later.
>> I see two choices: Either accept the Polaris results as broken, or force clamping everywhere to get the same results everywhere and adjust the expected values accordingly. In theory we could also just not test the borders, but I don't see how that would be better than clamping. My preference is option 2 because with all the ways fetch4 is broken the test accepts too large an amount of results already.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20190216/1df9a9cf/attachment.sig>

More information about the wine-devel mailing list