[PATCH 1/2] xaudio2: Rewrite to use FAudio

Ethan Lee elee at codeweavers.com
Tue Feb 19 10:26:58 CST 2019

I could keep the tests, but if FAudio gets more tests there’s no guarantee that they’ll get added to Wine as well.

But, the header change issue is totally valid. Would it make sense to replace the functionality tests with a big test function that references every struct member?


> On Feb 19, 2019, at 10:42 AM, Alexandre Julliard <julliard at winehq.org> wrote:
> Ethan Lee <elee at codeweavers.com> writes:
>> Those tests could be run here, but any failure of those deleted tests
>> would be an FAudio issue rather than a Wine issue.
> That would still be useful I think. It could also catch things like
> header changes that break the build etc.
> -- 
> Alexandre Julliard
> julliard at winehq.org

More information about the wine-devel mailing list