[PATCH 1/2] xaudio2: Rewrite to use FAudio

Alexandre Julliard julliard at winehq.org
Tue Feb 19 12:55:34 CST 2019

Ethan Lee <elee at codeweavers.com> writes:

> I could keep the tests, but if FAudio gets more tests there’s no
> guarantee that they’ll get added to Wine as well.
> But, the header change issue is totally valid. Would it make sense to
> replace the functionality tests with a big test function that
> references every struct member?

We have that kind of tests for other headers (cf. generated.c files),
and they could certainly be added for xaudio. But actual code is also

It's OK if new tests only get added to FAudio and not Wine, but I don't
see a reason not to preserve the existing working tests.

Alexandre Julliard
julliard at winehq.org

More information about the wine-devel mailing list