[PATCH 1/2] xaudio2: Rewrite to use FAudio

Ethan Lee elee at codeweavers.com
Tue Feb 19 14:19:29 CST 2019

Very well, I can undo the test removal… is there an example of a generated header test I can look at when making the XAudio2 version?

Let me know if there’s anything else of interest in this patch, I’ll resubmit this with just the existing tests added back and submit a separate patch for the header tests.


> On Feb 19, 2019, at 1:55 PM, Alexandre Julliard <julliard at winehq.org> wrote:
> Ethan Lee <elee at codeweavers.com> writes:
>> I could keep the tests, but if FAudio gets more tests there’s no
>> guarantee that they’ll get added to Wine as well.
>> But, the header change issue is totally valid. Would it make sense to
>> replace the functionality tests with a big test function that
>> references every struct member?
> We have that kind of tests for other headers (cf. generated.c files),
> and they could certainly be added for xaudio. But actual code is also
> useful.
> It's OK if new tests only get added to FAudio and not Wine, but I don't
> see a reason not to preserve the existing working tests.
> -- 
> Alexandre Julliard
> julliard at winehq.org

More information about the wine-devel mailing list